Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools

Ivan Timofeev <timofeev.i.s -AT- gmail.com>
Mon, 06 Feb 2012 12:03:15 +0400

06.02.2012 00:13, Chr. Rossmanith пишет:

I've added a third parameter nType to ResData2Output() (s. reworked
attached patch)

The following string concatenation argument have to be passed as aparameter as well.


+            if ( pResData->bText )
+                sOutput += pResData->sTextTyp;
+            else if ( pResData->bQuickHelpText )
+                sOutput += "QuickHelpText";
+            else if ( pResData->bTitle )
+                sOutput += "Title";

Otherwise, it would be always chosen from the first true branch.

Ivan

Context

[PATCH] Reduced duplicate code (simian) / l10ntools · Chr. Rossmanith
- Re: [PATCH] Reduced duplicate code (simian) / l10ntools · Ivan Timofeev
  - Re: [PATCH] Reduced duplicate code (simian) / l10ntools · Chr. Rossmanith
    - Re: [PATCH] Reduced duplicate code (simian) / l10ntools · Ivan Timofeev
      - Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools · Chr. Rossmanith
        
        Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools · Ivan Timofeev
        
        Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools · Chr. Rossmanith
        
        Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools · Ivan Timofeev
        Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools · Chr. Rossmanith
        [PUSHED] Reduced duplicate code (simian) / l10ntools · Ivan Timofeev
        Re: [PUSHED] Reduced duplicate code (simian) / l10ntools · Chr. Rossmanith

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.