Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


Hi,

I've moved them to a method ResData2Output(). Please review.

Looks nice. All of the differences seem to be handled...

> bWriteNoSlash seems to be always false
I'll add this to the patch and wait until I get feed back wrt the test question (s. below) before I'll push.

Yes. And ByteString sTmp is unused.
I'll add this as well.

Maybe the spelling of Semikolon should be changed while at it...

Yes, I think.
And this one...

and ByteString->rtl::OString...

I think it should be separated... :)
Of course.

Hmm, interesting, where we can test the "new" code, just in case?
That must be answered by someone else. "make unitcheck" is on its way but I don't know if l10ntools has unittests...

Christina


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.