Re: [PATCH] Reduced duplicate code (simian) / l10ntools

05.02.2012 23:37, Chr. Rossmanith пишет:
> > > I've moved them to a method ResData2Output(). Please review.
> >
> > Looks nice. All of the differences seem to be handled...

Oh, oh, oh! No, we must pass all the different values as paramerers to 
the function.

Because it was

if ( pEntry && pResData->bText ) {
...
}
if ( pEntry && pResData->bQuickHelpText ) {
...
}
if ( pEntry && pResData->bTitle ) {
...
}

, but not "if - else if - else if"; and thus nType and sOutput will be 
always the same in these 3 calls to ResData2Output.

I'm sorry...

Ivan