Re: [PATCH] Reduced duplicate code (simian) / l10ntools

Ivan Timofeev <timofeev.i.s -AT- gmail.com>
Sun, 05 Feb 2012 22:52:52 +0400

Hi Christina,

05.02.2012 20:26, Chr. Rossmanith пишет:

there were three blocks of nearly identical code.


Awful! Thanks for working on this task.

I've moved them to a method ResData2Output(). Please review.


Looks nice. All of the differences seem to be handled...

> bWriteNoSlash seems to be always false

Yes. And ByteString sTmp is unused.

Maybe the spelling of Semikolon should be changed while at it...


Yes, I think.

and ByteString->rtl::OString...


I think it should be separated... :)

Hmm, interesting, where we can test the "new" code, just in case?

Ivan

Context

[PATCH] Reduced duplicate code (simian) / l10ntools · Chr. Rossmanith
- Re: [PATCH] Reduced duplicate code (simian) / l10ntools · Ivan Timofeev
  - Re: [PATCH] Reduced duplicate code (simian) / l10ntools · Chr. Rossmanith
    - Re: [PATCH] Reduced duplicate code (simian) / l10ntools · Ivan Timofeev
      - Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools · Chr. Rossmanith
        
        Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools · Ivan Timofeev
        
        Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools · Chr. Rossmanith
        
        Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools · Ivan Timofeev
        Re: [PATCH reworked] Reduced duplicate code (simian) / l10ntools · Chr. Rossmanith
        [PUSHED] Reduced duplicate code (simian) / l10ntools · Ivan Timofeev
        Re: [PUSHED] Reduced duplicate code (simian) / l10ntools · Chr. Rossmanith

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.