2012/2/1 Michael Stahl <mstahl@redhat.com>:
On 01/02/12 12:42, Stephan Bergmann wrote:
On 02/01/2012 12:01 PM, Michael Stahl wrote:
actually regressions should be easy to prevent here: just build 2 full
trees with all options, e.g. enable all extensions, help, all languages;
then diff the files produced by the tools.
In principle at least (and I'll surely do tests along these lines). In
practice however, things are a little harder. Complete input data
(--with-lang=all) is huge; what parts exactly of the build (*/$INPATH/*)
to copy aside for later comparison is not always glaringly evident;
doing changes incrementally would conflict with other people's commits
invalidating the comparison data saved upfront.
hence "build 2 full trees"
yes, that will take lots of disk space.
New tool does not have to produce identical result. It must produce
syntactically equivalent result. If we reproduced all
tab/space/linefeed uglyness in generated xml/src files with new code,
then new code would be as ugly as old. :) So plain old diff is not the
right tool for this IMHO.
Andras
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.