Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 31/01/12 17:31, Ivan Timofeev wrote:
> 31.01.2012 21:12, Noel Power пишет:
> > should remove the first occurrence, care to fix ?
>
> so the exact equivalent of
>
> mpSdCustomShow->Remove(pPage->GetSdrPage())
>
> will be:
>
> SdCustomShow::PageVec::iterator it = std::find(
>     mpSdCustomShow->PagesVector().begin(),
>     mpSdCustomShow->PagesVector().end(),
>     pPage->GetSdrPage());
> if (it != mpSdCustomShow->PagesVector().end())
>     mpSdCustomShow->PagesVector().erase(it);
hey I've already proved my (non) STL credentials :-) , but.. if we are 
to believe the old code then 
mpSdCustomShow->Remove(pPage->GetSdrPage()); would call 
Container::Remove( void* p ) which would call Container::Remove( 
Container::GetPos( p ) ) which afaics deletes the first match :-) and 
that's what your patch seems to do, don't know if there is a briefer way 
to specify that but to me what you have looks fine


Noel