Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

Ivan Timofeev <timofeev.i.s -AT- gmail.com>
Tue, 31 Jan 2012 19:24:02 +0400

31.01.2012 18:22, Noel Power пишет:

On 30/01/12 13:54, Noel Grandin wrote:

Attached patch converts SdCustomShow to use std::vector.

I hate these remove list etc. type patches as they tend to be tricky and
time consuming to look at ;-) . The patch looked ok for me, hopefully if
I missed something ( 'cause these really are tricky ) then someone else
will spot it.

std::remove doesn't remove elements from the vector. It just moves theelements to the front. So we have to 'vector::erase' garbage whenreplacing RemovePage by std::remove. Am I right?


Ivan

Context

[Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector · Noel Grandin
- Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector · Noel Power
  - Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector · Ivan Timofeev
    - Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector · Noel Grandin
      - Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector · Ivan Timofeev
        
        Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector · Noel Grandin
        
        Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector · Ivan Timofeev
        
        Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector · Noel Power
        
        Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector · Ivan Timofeev
        Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector · Noel Power
        Re: [Libreoffice] [PUSHED][PATCH V2] convert SdCustomShow from tools/list to vector · Ivan Timofeev
        
        Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector · Eike Rathke
        
        Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector · Noel Power

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.