Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 31/01/12 15:55, Ivan Timofeev wrote:
> 31.01.2012 19:42, Noel Grandin пишет:
> > So I should be calling
> > maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) );
> > ??
>
> maPages.erase( std::remove(maPages.begin(), maPages.end(), pOldPage), 
> maPages.end() );
>
> I'll fix that.
>
> Ivan
nice catch, I admit not being familiar with this but I did read 
"http://en.cppreference.com/w/cpp/algorithm/remove"; and even read the 
second paragraph where it mentions the items are removed but fails ( imo 
) to clearly indicate the removed items are not removed. Sure if you 
read it *very carefully* you get it :-/ ( appears I am not careful enough )