Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

Stephan Bergmann <sbergman -AT- redhat.com>
Tue, 31 Jan 2012 17:17:14 +0100

On 01/31/2012 03:22 PM, Noel Power wrote:

I hate these remove list etc. type patches as they tend to be tricky and
time consuming to look at ;-) . The patch looked ok for me, hopefully if
I missed something ( 'cause these really are tricky ) then someone else
will spot it. Anyway thanks again for the nice patch. So... pushed to
master


Looks like you missed to run make check:

LOG> 1. removeByIndex("1") ...OK
LOG> removing a non existent object to get an exception
LOG> 2. removeByIndex(): Expected exception - OK
Method removeByIndex() finished with state FAILED
LOG> removeByIndex(): PASSED.FAILED
***** State for sd.SdXCustomPresentation::com::sun::star::container::XIndexContainer ******
[sd.SdXCustomPresentation::com::sun::star::container::XIndexContainer::removeByIndex()] is 
testcode: [removeByIndex()] - PASSED.FAILED


Guess Ivan's fix will rectify that.

Stephan

Context

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector (continued)

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.