[Libreoffice] Do we support classic and industrial theme? (was: [PATCH] configure.in examples: options shouldn't have quote)

Hello all,

/me separate this into new thread. :)

On Sun, Dec 11, 2011 at 11:47, Korrawit Pruegsanusak
<detective.conan.1412@gmail.com> wrote:
> Last but not least, I've noticed that there are two themes, classic
> and industrial, that described in AS_HELP_STRING (see context in first
> patch) but not detected while checking (see context in second patch).
> That is, if user pass e.g. --with-theme=classic, it'll fail. So, do we
> really support classic and industrial themes? I've found them listed
> on ooo_custom_images [1], but I'm not sure if it's relevant.
>
> [1] http://opengrok.libreoffice.org/xref/core/ooo_custom_images/

I've tried to build [2] on cygwin regarding this, adding "classic" and
"industrial" into configure.in [3], and result as follows:

--with-theme="classic industrial" - no icons at all, no checkboxes, no
theme names in "Tools > Options > View > Icon size and style" (has
only "Automatic"). Anyway, overall is somewhat usable, but looks very
ugly.

--with-theme="default classic industrial" - it opens with default
theme, overall was as expected, but has only "Galaxy (default)" in
theme option.

--with-theme="default hicontrast oxygen classic industrial" - like
second one, three theme options, and also none of "classic" nor
"industrial".

Maybe a clean build needed? I'm on cygwin, so I wouldn't like `make
clean` much ;)
or maybe configure options related? (I don't think so)

[2] incremental build after success build at
faa285f2679c842b641ca721141218d826bf7ab7 (Dec 2, 2011)
[3] diff as follows:
diff --git a/configure.in b/configure.in
index f8aed0e..132e022 100644
--- a/configure.in
+++ b/configure.in
@@ -8034,7 +8034,7 @@ fi
 WITH_THEMES=""
 for theme in $with_theme; do
     case $theme in
-        default|crystal|hicontrast|oxygen|tango) : ;;
+        default|crystal|hicontrast|oxygen|tango|classic|industrial) : ;;
         *) AC_MSG_ERROR([Unknown value for --with-theme: $theme]) ;;
     esac
     WITH_THEMES="$WITH_THEMES $theme"


Best Regards,
-- 
Korrawit Pruegsanusak