Re: [Libreoffice] Do we support classic and industrial theme? (was: [PATCH] configure.in examples: options shouldn't have quote)

Hi Korrawit,

On Sun, 2011-12-11 at 21:39 +0700, Korrawit Pruegsanusak wrote:
> [3] diff as follows:
> diff --git a/configure.in b/configure.in
> index f8aed0e..132e022 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -8034,7 +8034,7 @@ fi
>  WITH_THEMES=""
>  for theme in $with_theme; do
>      case $theme in
> -        default|crystal|hicontrast|oxygen|tango) : ;;
> +        default|crystal|hicontrast|oxygen|tango|classic|industrial) : ;;
>          *) AC_MSG_ERROR([Unknown value for --with-theme: $theme]) ;;
>      esac
>      WITH_THEMES="$WITH_THEMES $theme"

        I suggest we push your patch; industrial is used as layer in a stack of
layers used to build other themes, so we can't remove those icons from
git; but the classic stuff we're well rid of - and it won't keep up with
new icon names / movements etc. I suspect. The classic tar-ball is still
in git as a static un-maintained blob; we could prolly remove that too
in master - if you knock up a new patch that can be git am'd ;-) ...

        HTH,

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot