Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

Hi August,

On 17/11/11 16:52, August Sodora wrote:
> > a minor fix ) So, what I suggest is to mail the patch to me/list and I will>  test/integrate it ( 
> > already I fear some manual merging will be necessary as
> Everything is pushed to the branch feature/line-numbers-in-basicIDE.
>
> > I have added a 'Goto Line' menu to the IDE yesterday and it will certainly
> > conflict with your patch.
I see Norbert has already integrated that, just some points to remember, 
for new files don't forget to add a license header ( I added that for 
linenumberwindow.[ch]xx ) Also, only items that raise dialogs should end 
with '...' I corrected the string for that.. You can see the changes 
here ->  
http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd48c0eead825326ce1ee31d043185a79e7fa87f
> I was looking at this and was wondering if it made sense to factor out
> the dialog into its own hxx/cxx. I'd very much like to see the whole
> group of baside*.cxx get turned into something more meaningful where
> it is easier to find a specific piece of functionality.

I'm not a major fan of slavishly imposing a rule of individual [ch]xx 
files per class, this is especially true for minor ( & tiny ) classes 
used only internally ( as is the case here ) in fact I think probably 
there was no need for this new dialog to appear in header file, thinking 
about it, the class could/should have been internalised in the source 
file where it is used. In general though.
hth,

thanks again
Noel