Re: [Libreoffice] [PATCH] Added line numbers to the basic ide

> There are a couple problems as you mention with this patch, however I do> think that this is 
> *really* useful land certainly something that I would have> liked to see at times. However 
> sometimes I think the line numbers can just> be annoying ;-) so I think definitely this should be 
> configurable :-)
Of course :-) I was looking at the stuff in cui for adding an option
somewhere, is that the correct place to be looking? Also I'm not sure
if the basic ide deserves its own entire category for options yet as I
think this is the first configurable thing about the basic ide.

> The erratic behaviour of the vertical scrollbar ( note it doesn't respond to
> clicks ) is I believe due to the fact that you probably don't take into
> account the reduced size of the editor window ( because now there is the
> extra width from the window with the line numbers ) and in fact the width of
> that line-number window is dynamic ( e.g. can change as you are typing when
> the number of lines increases ). What I suspect is happening is the editor
> window area extends over where the scrollbar is painted and the 'flicker'
> and erratic 'positioning' is as a result of the the editor window and scroll
> bar painting over one another.

This was my first reaction but I couldn't find anything on my first
pass through; I'll definitely take a deeper look.

> given the current state would you consider moving this to a feature branch
> where perhaps others might be able to check it out and collaborate/help ?
> Although I am not very familiar with vcl and/or ui stuff, I'd be happy to
> try and help.

I'd love to but I'm not exactly sure how. Currently I have it as a local branch.

August Sodora
augsod@gmail.com
(201) 280-8138



On Fri, Nov 11, 2011 at 11:09 AM, Noel Power <nopower@suse.com> wrote:
> On 10/11/11 03:02, August Sodora wrote:
> > Hello,
> >
> > I've attached a patch that attempts to add line numbers to the basic
> > ide. I believe it is mostly correct, although I am seeing a couple of
> > rendering issues that I haven't been able to track down yet. First,
> > the scrollbar seems to jump around and flicker a lot more than it does
> > without this patch. Second, typing so that the window has to scroll
> > horizontally causes the vertical scrollbar to move to a nonsensical
> > position. If anybody has a moment to take a look at this I would
> > really appreciate it! This has been bugging me for a while.
> There are a couple problems as you mention with this patch, however I do
> think that this is *really* useful and certainly something that I would have
> liked to see at times. However sometimes I think the line numbers can just
> be annoying ;-) so I think definitely this should be configurable :-)
>
> The erratic behaviour of the vertical scrollbar ( note it doesn't respond to
> clicks ) is I believe due to the fact that you probably don't take into
> account the reduced size of the editor window ( because now there is the
> extra width from the window with the line numbers ) and in fact the width of
> that line-number window is dynamic ( e.g. can change as you are typing when
> the number of lines increases ). What I suspect is happening is the editor
> window area extends over where the scrollbar is painted and the 'flicker'
> and erratic 'positioning' is as a result of the the editor window and scroll
> bar painting over one another.
>
> given the current state would you consider moving this to a feature branch
> where perhaps others might be able to check it out and collaborate/help ?
> Although I am not very familiar with vcl and/or ui stuff, I'd be happy to
> try and help.
>
> Noel