customshapepresets.cxx is just too much for gcc

Tor Lillqvist <tml -AT- iki.fi>
Fri, 7 Oct 2011 18:53:27 +0300

- I don't think we can expect developers to run a build before each
push,


Yes we absolutely can expect that. it is actually a bare minimum !!!!!


And on multiple platforms? Or at least with a bit of
portability-enforcing options to gcc? Case in point: commit
1fc34c75a8a2356ed03c52ca839a7ad771c51ba1 , which breaks compilation
with MSVC of some plain old *C* files in soltools/javadep.

Please, use cppcheck only on C++ files. C is not C++. gcc with its
default settings is not a proper *C89* compiler.

Flames about C99 being over ten years old already to /dev/null,
please. Voluntary technical standards that significant industry
participants choose to mostly ignore are mostly worthless.

--tml

Context

Re: [Libreoffice] oox/source/drawingml/customshapepresets.cxx - generated code ... (continued)

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.