Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes

Jan Holesovsky <kendy -AT- suse.cz>
Wed, 05 Oct 2011 16:46:44 +0200

Hi Maciej,

On 2011-10-05 at 10:39 +0200, Maciej Rumianowski wrote:

There was a lot of WW8Bytes( SV_DECL_VARARR ) which was partly replaced
with ww::bytes. This set of patches totally migrates code to ww::bytes.


Very nice, thank you! :-)

Before pushing, I wonder - ww::bytes is std::vector<sal_uInt8>; is there
a reason not to make it std::basic_string<sal_uInt8> instead?  That
would allow you to convert the pO->GetData() to something like
po->data(), instead of &(*pO)[0] (and similar) used on many places...

Thank you,
Kendy

Context

[Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes · Maciej Rumianowski
- Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes · Jan Holesovsky
  - Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes · Lubos Lunak
    - Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes · Maciej Rumianowski
      - Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes · Michael Stahl
        
        Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes · Stephan Bergmann
        
        Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes · Maciej Rumianowski
      - [Libreoffice] [PUSHED] Re: [PATCH] Replace WW8Bytes with ww::bytes · Jan Holesovsky
        
        Re: [Libreoffice] [PUSHED] Re: [PATCH] Replace WW8Bytes with ww::bytes · Maciej Rumianowski

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.