Re: [Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes

On Wednesday 05 of October 2011, Jan Holesovsky wrote:
> Hi Maciej,
>
> On 2011-10-05 at 10:39 +0200, Maciej Rumianowski wrote:
> > There was a lot of WW8Bytes( SV_DECL_VARARR ) which was partly replaced
> > with ww::bytes. This set of patches totally migrates code to ww::bytes.
>
> Very nice, thank you! :-)
>
> Before pushing, I wonder - ww::bytes is std::vector<sal_uInt8>; is there
> a reason not to make it std::basic_string<sal_uInt8> instead?

 How about the fact that ww:bytes is not, in fact, a string? At least as far 
as I can see.

> That would allow you to convert the pO->GetData() to something like
> po->data(), instead of &(*pO)[0] (and similar) used on many places...

 That same would be allowed by 
class bytes : public std::vector<sal_uInt8>
{
public:
const sal_uInt8* data() const { return &front(); }
...

-- 
 Lubos Lunak
 l.lunak@suse.cz