On 10/05/2011 09:13 AM, Kevin Hunter wrote:
At 2:58am -0400 Wed, 05 Oct 2011, Stephan Bergmann wrote:On 10/04/2011 11:01 PM, Kevin Hunter wrote:Here is a second patch that compiles, /should/ respond to what you just confirmed was the original intent, but is untested. (It was a random drive by patching.) Specifically, I suppose it's obvious that this now changes the semantics of it actually used to do. If you know how to test it ...Yes, that's how I would have done it, too. Pushed now, thanks again. (I assume you already stated somewhere what license your contributions are under, even though that's not explicitly listed at <http://wiki.documentfoundation.org/Development/Developers>.)Incidentally, do we have a set of tests for this? I wouldn't know where to begin. This was truly a "drive-by" reading of a commit and surrounding code.
Unfortunately, there's no good unit tests for this code. Blame it on me for taking the all too easy road out and committing the fix without doing the boring ^H^H^H joyful work of adding a test for it first.
That said, people wanting to write unit tests for the introspection stuff would be more than welcome! There's definitely things to unearth there...
-Stephan