Re: [Libreoffice] [PATCH] [PUSHED] .: stoc/source

Kevin Hunter <hunteke -AT- earlham.edu>
Wed, 05 Oct 2011 03:13:14 -0400

At 2:58am -0400 Wed, 05 Oct 2011, Stephan Bergmann wrote:

On 10/04/2011 11:01 PM, Kevin Hunter wrote:

Here is a second patch that compiles, /should/ respond to what you just
confirmed was the original intent, but is untested. (It was a random
drive by patching.) Specifically, I suppose it's obvious that this now
changes the semantics of it actually used to do. If you know how to test
it ...


Yes, that's how I would have done it, too. Pushed now, thanks again. (I
assume you already stated somewhere what license your contributions are
under, even though that's not explicitly listed at
<http://wiki.documentfoundation.org/Development/Developers>.)

Incidentally, do we have a set of tests for this? I wouldn't know whereto begin. This was truly a "drive-by" reading of a commit andsurrounding code.


Thanks,

Kevin

Context

Re: [Libreoffice] [Libreoffice-commits] .: stoc/source · Kevin Hunter
- Re: [Libreoffice] [PATCH] [Libreoffice-commits] .: stoc/source · Kevin Hunter
- Re: [Libreoffice] [Libreoffice-commits] .: stoc/source · Stephan Bergmann
  - Re: [Libreoffice] [Libreoffice-commits] .: stoc/source · Kevin Hunter
    - Re: [Libreoffice] [PATCH] [PUSHED] .: stoc/source · Stephan Bergmann
      - Re: [Libreoffice] [PATCH] [PUSHED] .: stoc/source · Kevin Hunter
        
        Re: [Libreoffice] [PATCH] [PUSHED] .: stoc/source · Michael Meeks
        
        Re: [Libreoffice] [PATCH] [PUSHED] .: stoc/source · Kevin Hunter
        
        Re: [Libreoffice] [PATCH] [PUSHED] .: stoc/source · Kevin Hunter
      - Re: [Libreoffice] [PATCH] [PUSHED] .: stoc/source · Kevin Hunter
        
        Re: [Libreoffice] [PATCH] [PUSHED] .: stoc/source · Stephan Bergmann
        
        Re: [Libreoffice] [PATCH] [PUSHED] .: stoc/source · Kevin Hunter

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.