On Fri, Sep 30, 2011 at 3:26 AM, Caolán McNamara <caolanm@redhat.com> wrote:
On Fri, 2011-09-30 at 02:15 -0500, Norbert Thiebaud wrote:
When removing 'unused' code using unusedcode.easy, if you have an
accessor pair GetFoo()/SetFoo() and only one of these is unused,
please do not delete it.
Why :-)
because then I won't have to resurrect the code when trying to merge
patches... :-)
but more generally: either the accessor is not useful and both set and
get can go, or it is and the fact that one side is not used is more a
signe that someone is not using it when it should or not using it
_yet_
Norbert
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.