Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index



On Mon, 2011-09-26 at 17:33 +0200, Stephan Bergmann wrote:
A timed wait is no solution here.  (Timeouts in this kind of code pose 
at least two problems.  For one, they prevent a human from coming back 
to a hung "make check" after a while, only to find out they no longer 
get a clue where it hang, as the build has unhelpfully been forced to 
move forward.

        That is of course possible; however in this case the build would simply
fail with an assertion at this exact point. In general, that is probably
better than hanging indefinitely, which can wedge tinderboxes, and give
the impression the build is continuing when it has hung.

The real solution, instead, is to not only wait on the Result object,
but also on the OfficeConnection. Fixed  as 

        Looks like an improvement to me, thanks for that. I wonder why we only
see this now, surely smoketests have died in mid-flow before ?

        Regards,

                Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.