Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391

On Tue, 2011-09-20 at 14:25 +0400, Ivan Timofeev wrote:
> I'm glad to see my patches in master! :-) Thanks!
>
> 2011/9/20 Caolán McNamara <caolanm@redhat.com>:
> > I don't *think* we need to move the code around, the check for empty is
> > sufficient so I shrank it down to that bit.
>
> Hmm, when in "brochure" layout, try to input incorrect range and you
> will see "No pages" on the print preview, but in normal layout there
> is no such label. So, I think this lines should (?) be moved below the
> newly introduced check.

Ah, I got you now. I was focused just on the crash. In normal layout the
dialog continue to display the last "valid" range, while in brochure
layout it displays the current range. 

Hmm, if in normal mode I type in 3-4 I get that range previewed, change
it to "foobar" and it stays previewing 3-4, which isn't great either
really.

C.