Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391

Ivan Timofeev <timofeev.i.s -AT- gmail.com>
Tue, 20 Sep 2011 14:25:13 +0400

I'm glad to see my patches in master! :-) Thanks!

2011/9/20 Caolán McNamara <caolanm@redhat.com>:

I don't *think* we need to move the code around, the check for empty is
sufficient so I shrank it down to that bit.


Hmm, when in "brochure" layout, try to input incorrect range and you
will see "No pages" on the print preview, but in normal layout there
is no such label. So, I think this lines should (?) be moved below the
newly introduced check. Or am I wrong?

Context

[Libreoffice] [PATCH] Fix for fdo#38391 · Ivan Timofeev
- [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391 · Caolán McNamara
  - (message not available)
    - Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391 · Ivan Timofeev
      - Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391 · Ivan Timofeev
      - Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391 · Caolán McNamara
        
        Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391 · Ivan Timofeev
        
        Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391 · Caolán McNamara
        
        Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391 · Ivan Timofeev
        Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391 · Caolán McNamara
        Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391 · Ivan Timofeev
        Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391 · Caolán McNamara
        Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391 · Ivan Timofeev
        Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391 · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.