Hi Kohei, On Friday, 2011-09-02 23:53:51 -0400, Kohei Yoshida wrote:
I guess the major fear isn't that your code is wrong, it's probably right, it's what stuff relying on the old way of doing things will change.So, I was wondering why the default row height of a new Calc document has suddenly shrunk from the old 0.18" (in 3.4) to 0.15" on master. After looking at various places, I have eventually truck it down to this particular change. Also, the heights of the controls are overall noticeably shorter. But based on what I'm seeing on this thread, I take that the new glyph metric calculation algorithm is the correct way? If so, then we'll have to make some adjustments to some of the size sensitive areas to bring things back to the way they were prior to the change. One place I definitely have to adjust is the default row height, which is now noticeably smaller.
Yes, that would indeed be needed. Probably also import/export from/to Excel needs new row-height calculation, as they specify row height in fractions of font height, IIRC.
But before going there, I just need to make sure that we are on the same page wrt keeping the new algorithm and moving on to fixing whatever needs fixing.
I'm not sure we want to keep the new algorithm as default, given that there are probably many areas in several applications to be adapted to the new behavior. Maybe best we make that an option until necessary changes are done. Opinions? Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD
Attachment:
signature.asc
Description: Digital signature