Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists"

On Fri, Aug 05, 2011 at 03:22:35PM +0100, Caolán McNamara wrote:
> On Fri, 2011-08-05 at 16:13 +0200, Lionel Elie Mamane wrote:
> > In libreoffice-3-4, file svtools/inc/svtools/fileview.hxx:

> > #define FILEVIEW_SHOW_TITLE                     0x0010
> > #define FILEVIEW_SHOW_SIZE                      0x0020
> > #define FILEVIEW_SHOW_DATE                      0x0040
> > #define FILEVIEW_SHOW_ALL                       0x0070
> > #define FILEVIEW_SHOW_NONE                      0x00A0

> > In my opinion, we should seriously consider changing
> > FILEVIEW_SHOW_NONE to

> > #define FILEVIEW_SHOW_NONE                      0x0080

> Sure, go for it.

So, here's the patch. I recompiled with it applied, libreoffice did
not completely break, I could open files (the open file dialog looked
alright), close them, do some random edits.

I generated it against libreoffice-3-4, but it should apply cleanly
against master, too.

-- 
Lionel

From 6197c1117b5381e65d81deab053f771ea4903801 Mon Sep 17 00:00:00 2001
From: Lionel Elie Mamane <lionel@mamane.lu>
Date: Fri, 5 Aug 2011 16:27:29 +0200
Subject: [PATCH] make FILEVIEW_SHOW_NONE disjoint of FILEVIEW_SHOW_ALL

---
 svtools/inc/svtools/fileview.hxx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/svtools/inc/svtools/fileview.hxx b/svtools/inc/svtools/fileview.hxx
index b3678d7..2ddf6e9 100644
--- a/svtools/inc/svtools/fileview.hxx
+++ b/svtools/inc/svtools/fileview.hxx
@@ -47,7 +47,7 @@
 #define FILEVIEW_SHOW_SIZE                     0x0020
 #define FILEVIEW_SHOW_DATE                     0x0040
 #define FILEVIEW_SHOW_ALL                      0x0070
-#define FILEVIEW_SHOW_NONE                     0x00A0
+#define FILEVIEW_SHOW_NONE                     0x0080
 
 class ViewTabListBox_Impl;
 class SvtFileView_Impl;
-- 
1.7.2.5