Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists"

Caolán McNamara <caolanm -AT- redhat.com>
Fri, 05 Aug 2011 15:22:35 +0100

On Fri, 2011-08-05 at 16:13 +0200, Lionel Elie Mamane wrote:

In libreoffice-3-4, file svtools/inc/svtools/fileview.hxx:

#define FILEVIEW_SHOW_TITLE                     0x0010
#define FILEVIEW_SHOW_SIZE                      0x0020
#define FILEVIEW_SHOW_DATE                      0x0040
#define FILEVIEW_SHOW_ALL                       0x0070
#define FILEVIEW_SHOW_NONE                      0x00A0

In my opinion, we should seriously consider changing
FILEVIEW_SHOW_NONE to

#define FILEVIEW_SHOW_NONE                      0x0080


Sure, go for it.

This could be an incompatible ABI change


Nah, basically the only things that change external ABI are fiddling
with pre-existing .idl files or the libs that end up in the ure/lib dir.
So svtools is fair game for any change.

C.

Context

[Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists" · Lionel Elie Mamane
- Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists" · Caolán McNamara
  - Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists" · Lionel Elie Mamane
    - Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists" · Caolán McNamara
      - Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists" · Markus Mohrhard
        
        Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists" · Lionel Elie Mamane
        
        Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists" · Caolán McNamara
      - Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists" · Lionel Elie Mamane
        
        [Libreoffice] [PUSHED] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists" · Caolán McNamara
        
        Re: [Libreoffice] [PUSHED] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists" · Lionel Elie Mamane

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.