Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

Attached is another patch (in libs-gui repo) that is in 3.4 but not in 3.3 
found with lo-commit-stat using: 
<root>/bin $>perl lo-commit-stat --log-dir='./' --log-suffix='mjWCRL-3.3'
--rev-list ../ --until='2010-12-01' --author='Johnsson'
origin/libreoffice-3-4 ^origin/libreoffice-3-3

and shown more directly by rev-list using: 
<root>/clone/libs-gui $> git rev-list --after='2010-10-01'
--before='2011-01-01' --pretty=medium origin/libreoffice-3-4
^origin/libreoffice-3-3 > ../../bin/libs-gui-rev3.4to3.3.log

A search through the result for 'Mattias' gives:
commit cb9aa439fbb0a85829b1e61e292b1553512b0cb5
Author: Mattias Johnsson &lt;m.t.johnsson@gmail.com&gt;
Date:   Thu Nov 4 23:25:02 2010 +1100

    An opening quote should not be counted as a word by word count tool

Patch file: 
http://nabble.documentfoundation.org/file/n3094191/0001-An-opening-quote-should-not-be-counted-as-a-word-by-.patch
0001-An-opening-quote-should-not-be-counted-as-a-word-by-.patch 

There is only one change in the patch: 
+++ b/i18npool/source/breakiterator/breakiteratorImpl.cxx
...
+    {UBLOCK_GENERAL_PUNCTUATION, UBLOCK_GENERAL_PUNCTUATION,
ScriptType::LATIN},
...

This addition to the (character class definitions?) stuff used by the break
iterator elegantly fixes the leading quote as separate word problem.  The
power of that single line left me: 
 -- wondering why only the leading quote and not the trailing quote went as
a separate word (breakIterator wouldn't tell me ;-), and 
 -- wondering about any other effects that this insertion may have.  

That said, if the symptom you are trying to fix is the 'leading quote as
separate word' then AFAIK this patch by Mattias Johnsson fixed that in the
master of late last year and in 3.4 from its birth to today.

From a similar progression in clone/writer, it *looks like* all of Mattias'
word count patches have been applied to 3.3.  Since, 3.3 is counting with
and wthout spaces then Mattias writer patch was applied there (and I do
believe there is just one in writer == 
339eee93fd2a888b541eac4e7576d7091dfd1639).  I do not have a code config
pointed at 3.3 so I cannot look directly at the word count routines there.  

I am still at a loss as to why the redlining doesn't erase in 3.3 and does
in 3.4, given that the shallow copy + whiting out redlined text appears to
predate my patch and it appears to be present in 3.3 from looking at the
patches in 3.4.  Perhaps 3.4 contains other changes or my testing is off or
there is a later deep/full copy or ...  

Whatever else happens, 
1-- If my patch attached to the OP goes into 3.3 then it should
***definitely be followed by Cedric's fix*** attached to my first response.  
2-- Mattias' patch inserted above fixes the 'leading quote as word' problem.  

Hope this helps

LeMoyne


--
View this message in context: 
http://nabble.documentfoundation.org/PATCH-Fix-for-fdo-30550-Character-count-without-spaces-tp3092043p3094191.html
Sent from the Dev mailing list archive at Nabble.com.