Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

Hi John, Korrawit,

On Wed, 2011-07-06 at 22:51 +0700, Korrawit Pruegsanusak wrote:
> On Fri, Jun 24, 2011 at 14:38, John LeMoyne Castle
> <lemoyne.castle@gmail.com> wrote:
> >  -- you (and others) cannot reproduce fdo#37584 (redlined text disappears)
> > in 3-3 or 3-3-3 because my patch referenced in your original post [OP] is
> > not in the 3-3 branches.
>
> Hmm? I think it's caused by casting var:
>   String& rTextCopy = const_cast<String&>(m_Text);
> which Cedric fixed in
> http://cgit.freedesktop.org/libreoffice/writer/commit/?id=135cf4fdbec71e8d93edc0339e8617d50766f151
> Anyway, if it can't be reproduced, so let it be. (should not have
> further fix for -3-3)

You're both right... blame me for leading you into error because I
haven't had a look at the 3-3 branch code before writing my first email.

The copy mentioned by Korrawit isn't in the 3-3 branch... which explains
why the bug can't be reproduced there ;)

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr