Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index 

Noel Power wrote:

As far as I understand the code it consists merely of test calls
to functions in order to see if they return a valid result. I'm
quite sure that you already know whether it has side effects or
not... I vote for "it hasn't", but I'm absolutely not sure

nah, just seems like some testing to see if uno is bootstrapped and
the ucp stuff available, it looks to me especially in the case you
removed to be completely useless.
Btw if you are feeling frisky and wish to kill other related pieces
of uselessness :-) there are the  #ifdef _USE_UNO associated blocks
that you can see around the hasUno() method ( and others ) that need
some removing ( afaics _USE_UNO is defined always )


So we're safe to apply the original patch (with the improvements
suggested previously)?

Cheers,

-- Thorsten

Attachment: pgpUg1Vw1tAmm.pgp
Description: PGP signature

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.