Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Am 21.03.2011 18:10, schrieb Michael Meeks:
On Mon, 2011-03-21 at 13:44 +0100, Christina Roßmanith wrote:
I've removed all blocks of code #ifdef'ed by _OLD_FILE_IMPL because it
was never defined. It builds successfully. Could someone please review
to make sure that nothing was deleted accidentally?
@@ -427,7 +425,7 @@ void OslStream::SetSize( sal_uIntPtr nSize )
      maFile.setSize( (sal_uInt64)nSize );
  }

-#endif
+//#endif

        I would fully remove that :-)

-        if( !hasUno() )

        and hasUno has no side-effects ? ie. changes no global / local / object
state, and calls nothing that does that ?
As far as I understand the code it consists merely of test calls to functions in order to see if they return a valid result. I'm quite sure that you already know whether it has side effects or not... I vote for "it hasn't", but I'm absolutely not sure.

Christina

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.