Re: [Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

On Mon, 2011-03-21 at 13:44 +0100, Christina Roßmanith wrote:
> I've removed all blocks of code #ifdef'ed by _OLD_FILE_IMPL because it 
> was never defined. It builds successfully. Could someone please review 
> to make sure that nothing was deleted accidentally?

@@ -427,7 +425,7 @@ void OslStream::SetSize( sal_uIntPtr nSize )
     maFile.setSize( (sal_uInt64)nSize );
 }
 
-#endif
+//#endif
 
        I would fully remove that :-)

-        if( !hasUno() )

        and hasUno has no side-effects ? ie. changes no global / local / object
state, and calls nothing that does that ?

        Otherwise it looks perfect to me, go go go ! :-)

        And a nice cleanup too,

        Thanks,

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot