Re: [Libreoffice] [PUSHED] [PATCH] Additional translations of German comments in libs-core/sfx2/source/<bastyp, control, dialog>

Hi Muthu,
Thanks for pushing my patches! It is always nice to see them go in.

On Thu, Mar 10, 2011 at 18:38, Muthu Subramanian K <sumuthu@novell.com> wrote:
> Hi Albert,
>
> I have pushed after correcting a few typos - hope I have caught the
> important ones and most of the others.

Sorry for the typos, I try to review my patches before sending them
but some things you just don't see for some reason...

> If possible (in the future), please do compile and check the code before
> submitting the patch - I found some stray characters.

Yeah, compiling the code was he plan from the beginning, haven't
manage to do this yet, though.

> Thanks again for the (huge) patch...please do continue the good work.

There are more patches of mine further up the list. If someone has the
time to take care of them, please do.

    [Libreoffice] [PATCH] Additional translations of German comments
in libs-core/editeng   Albert Thuswaldner
        [Libreoffice] [PATCH] Additional translations of German
comments in libs-core/editeng   Albert Thuswaldner
        [Libreoffice] [PATCH] Additional translations of German
comments in libs-core/sfx2/inc   Albert Thuswaldner
    [Libreoffice] [PATCH] Additional translations of German comments
in libs-core/sfx2/sdi   Albert Thuswaldner
[Libreoffice] [PATCH] Additional translations of German comments in
libs-core/sfx2/source/appl   Albert Thuswaldner
    [Libreoffice] [PATCH] Additional translations of German comments
in libs-core/sfx2/source/appl   Albert Thuswaldner

I'm now a member of the mailing list. Please let me know if there are
problems applying my patches (merge conflicts and so on) . I can
always help out, fixing the patches and re-sending them. To make
things as smooth as possible for you poor guys/gals having to push
them. ;)

Cheers

/Albert

> @Martin: If possible, could you please help in re-reviewing this set? -
> would help us a lot - since the patch is big, there is a lot of
> probability that I might have missed some things. Thank you!
>
> - Muthu Subramanian
>
> On 03/10/2011 05:23 PM, Muthu Subramanian K wrote:
> > Thank you for resending. I am reviewing them...I will push them in a while.
> >
> > Yes, translating the debug messages, DBG_ASSERTS would also be really
> > helpful.
> >
> >
> > On 03/08/2011 05:30 AM, Martin Kepplinger wrote:
> > > Am 08.03.2011 00:23, schrieb Albert Thuswaldner:
> > > > Hi
> > > > Here are last ones that did not get pushed to master.
> > > >
> > > > You can commit the patch under the terms of MPL 1.1 / GPLv3+ / LGPLv3+
> > > > triple license.
> > > >
> > > > /Albert
> > >
> > > Hi Albert,
> > >
> > > Thanks for that work! These patches don't just translate german comments
> > > though. They translate debug-messages, delete comments, translate of
> > > course, fix typos and coding style issues.
> > >
> > > When nobody is faster, I could maybe look at them this week. But I'd
> > > need just another opinion on also translating DBG_ASSERT and such in one
> > > go, before I could push them. Sorry, I'm just not experienced enough here.
> > >
> > > thanks!
> > >      martin
> >
> > _______________________________________________
> > LibreOffice mailing list
> > LibreOffice@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/libreoffice