Re: [Libreoffice] [PATCH] [PUSHED] fixed spelling menues -> menus

On Wed, Feb 16, 2011 at 12:48:14PM +0100, David Tardon wrote:
> On Wed, Feb 16, 2011 at 07:56:06AM +0100, David Tardon wrote:
> > On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote:
> >
> > > diff --git a/svtools/source/config/menuoptions.cxx b/svtools/source/config/menuoptions.cxx
> > > index a12f1e0..4e814a7 100644
> > > --- a/svtools/source/config/menuoptions.cxx
> > > +++ b/svtools/source/config/menuoptions.cxx
> > > @@ -62,13 +62,13 @@ using namespace ::com::sun::star::uno ;
> > > -#define PROPERTYNAME_SHOWICONSINMENUES          
> > > OUString(RTL_CONSTASCII_USTRINGPARAM("ShowIconsInMenues"        ))
> > > -#define PROPERTYNAME_SYSTEMICONSINMENUES        
> > > OUString(RTL_CONSTASCII_USTRINGPARAM("IsSystemIconsInMenus"     ))
> > > +#define PROPERTYNAME_SHOWICONSINMENUS           
> > > OUString(RTL_CONSTASCII_USTRINGPARAM("ShowIconsInMenus"         ))
> > > +#define PROPERTYNAME_SYSTEMICONSINMENUS         
> > > OUString(RTL_CONSTASCII_USTRINGPARAM("IsSystemIconsInMenus"     ))
> >
> > I have removed the changes related to these properties. The property
> > names are documented and used at other places, so we cannot just change
> > them. As for the handles, they can be changed, as they are only used
> > locally, but IMHO it is better if the handle's name do not differ from
> > the property's name.
>
> Actually, this is not exactly true. These are not properties defined by
> UNO api, they are just configuration keys. I think if we allow reading
> of the old-spelled key for some time for compatibility and only write
> the new-spelled key, noone can want more.

Does not seem to be possible to do that cleanly and I do not want just
to hack something in just to correct spelling of config. key... I
suggest to wait for LibO 4 and then use migration to change the name of
the key (I have never looked in detail at how the migration stuff works,
but intuitively things like that should be possible).

D.