Re: [Libreoffice] [PATCH] [PUSHED] fixed spelling menues -> menus

Hi David,

Am 16.02.2011 07:56, schrieb David Tardon:
> On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote:
>
> > diff --git a/svtools/source/config/menuoptions.cxx b/svtools/source/config/menuoptions.cxx
> > index a12f1e0..4e814a7 100644
> > --- a/svtools/source/config/menuoptions.cxx
> > +++ b/svtools/source/config/menuoptions.cxx
> > @@ -62,13 +62,13 @@ using namespace ::com::sun::star::uno       ;
> > -#define PROPERTYNAME_SHOWICONSINMENUES          
> > OUString(RTL_CONSTASCII_USTRINGPARAM("ShowIconsInMenues"        ))
> > -#define PROPERTYNAME_SYSTEMICONSINMENUES        
> > OUString(RTL_CONSTASCII_USTRINGPARAM("IsSystemIconsInMenus"     ))
> > +#define PROPERTYNAME_SHOWICONSINMENUS           
> > OUString(RTL_CONSTASCII_USTRINGPARAM("ShowIconsInMenus"         ))
> > +#define PROPERTYNAME_SYSTEMICONSINMENUS         
> > OUString(RTL_CONSTASCII_USTRINGPARAM("IsSystemIconsInMenus"     ))
> I have removed the changes related to these properties.
OpenGrok does not show any changes after 03-Feb-2011. Did you really 
push something?
> names are documented and used at other places,
I've searched with "git grep" and OpenGrok and both found e.g. 
PROPERTYNAME_SHOWICONSINMENUES in menuoptions.cxx only. How else should 
I search? And what about the documentation? Where can I find it?
>   so we cannot just change
> them. As for the handles, they can be changed, as they are only used
> locally, but IMHO it is better if the handle's name do not differ from
> the property's name.
Christina