Re: [Libreoffice] [PATCH] [PUSHED] fixed spelling menues -> menus

On Sun, Feb 13, 2011 at 08:42:42PM +0100, Christina Roßmanith wrote:

> diff --git a/svtools/source/config/menuoptions.cxx b/svtools/source/config/menuoptions.cxx
> index a12f1e0..4e814a7 100644
> --- a/svtools/source/config/menuoptions.cxx
> +++ b/svtools/source/config/menuoptions.cxx
> @@ -62,13 +62,13 @@ using namespace ::com::sun::star::uno     ;
> -#define PROPERTYNAME_SHOWICONSINMENUES          
> OUString(RTL_CONSTASCII_USTRINGPARAM("ShowIconsInMenues"        ))
> -#define PROPERTYNAME_SYSTEMICONSINMENUES        
> OUString(RTL_CONSTASCII_USTRINGPARAM("IsSystemIconsInMenus"     ))
> +#define PROPERTYNAME_SHOWICONSINMENUS           
> OUString(RTL_CONSTASCII_USTRINGPARAM("ShowIconsInMenus"         ))
> +#define PROPERTYNAME_SYSTEMICONSINMENUS         
> OUString(RTL_CONSTASCII_USTRINGPARAM("IsSystemIconsInMenus"     ))

I have removed the changes related to these properties. The property
names are documented and used at other places, so we cannot just change
them. As for the handles, they can be changed, as they are only used
locally, but IMHO it is better if the handle's name do not differ from
the property's name.

I have not pushed the binfilter's patch, as I think it is not worth the
effort to change that obsoleted code.

D.