Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

Hello,
Sharp eyes.. Just to keep you trainded..:-(
No really sorry, Despite reviewing diff, I did not catch this one.
Will take more care


On 11/17/2010 05:18 PM, Caolán McNamara wrote:
> On Tue, 2010-11-16 at 22:39 +0100, Pierre-André Jacquod wrote:
> > On 11/16/2010 10:37 PM, Pierre-André Jacquod wrote:
> > > Hello,
> > > being off for some days, here the collection of patches I produced in
> > > between.
>
> Mostly good, but careful here, see...
>
> -        aAutoStr += ::rtl::OUString::createFromAscii( " (" );
> +        aAutoStr += ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("(") );
>
> you changed the string by accident from a bracket with a preceding space
> to one with no preceding space, clearly what's between "" has to remain
> the same :-). Fixed that typo and the rest looks good, pushed.
>
> C.
>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice