[Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

Caolán McNamara <caolanm -AT- redhat.com>
Wed, 17 Nov 2010 16:18:35 +0000

On Tue, 2010-11-16 at 22:39 +0100, Pierre-André Jacquod wrote:

On 11/16/2010 10:37 PM, Pierre-André Jacquod wrote:

Hello,
being off for some days, here the collection of patches I produced in
between.


Mostly good, but careful here, see...

-        aAutoStr += ::rtl::OUString::createFromAscii( " (" );
+        aAutoStr += ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("(") );

you changed the string by accident from a bracket with a preceding space
to one with no preceding space, clearly what's between "" has to remain
the same :-). Fixed that typo and the rest looks good, pushed.

C.

Context

[Libreoffice] [PATCH 01/12] RTL_CONSTASCII_USTRINGPARAM in components/cui/...option · Pierre-André Jacquod
- [Libreoffice] [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options · Pierre-André Jacquod
  - [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options · Caolán McNamara
    - Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options · Pierre-André Jacquod
      - Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options · Kevin Hunter
        
        Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options · Wols Lists
        
        Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options · Kevin Hunter
        
        Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options · Jan Holesovsky
        Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options · Wols Lists
        Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options · Jan Holesovsky
- [Libreoffice] [PATCH 03/12] RTL_CONSTASCII_USTRINGPARAM in components - forms · Pierre-André Jacquod
  - [Libreoffice] [PUSHED] Re: [PATCH 03/12] RTL_CONSTASCII_USTRINGPARAM in components - forms · Caolán McNamara
- [Libreoffice] [PATCH 04/12] RTL_CONSTASCII_USTRINGPARAM in components - inc · Pierre-André Jacquod

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.