Re: [Libreoffice] First build from sources

On Thu, Sep 30, 2010 at 09:13:33PM +0200, Thorsten Behrens wrote:
> Thomas Klausner wrote:
> > 2) configure searches for png.h in default paths, I think it should
> > use pkg-config instead. Suggested patch attached.
> Careful, there are platforms w/o proper pkg-config (see also
> https://bugs.freedesktop.org/show_bug.cgi?id=30485 for some
> attempts).

Well, the file already has a test demanding pkg-config and uses
PKG_CHECK_MODULES in 2 places, so I thought one more place won't hurt.

> > 4) configure ignores --with-num-cpus (even though the wiki says to use
> > it); --with-max-jobs seems to be handled better. Which one do we want,
> > or do we want both?
> Both. They are slightly orthogonal currently, in that max-jobs
> controls the number of parallel compiler runs inside a single
> directory, whereas num-cpus controls the number of parallel make
> invocations (in different directories). Yeah, it's weird.

Ah, I overlooked that BUILD_NCPUS is spread through various Makefiles
and thought it currently did nothing. Forget about this point :)

> > 5) download has /usr/bin/perl hardcoded as interpreter; it should
> > probably use "/usr/bin/env perl" instead.
> > Suggested patch attached.
> Looks good, pushed.

Thanks. (I do have commit access btw, since today.)

> Thanks for your fixes!

You're welcome!
 Thomas