Thomas Klausner wrote:
2) configure searches for png.h in default paths, I think it should use pkg-config instead. Suggested patch attached.
Careful, there are platforms w/o proper pkg-config (see also https://bugs.freedesktop.org/show_bug.cgi?id=30485 for some attempts).
4) configure ignores --with-num-cpus (even though the wiki says to use it); --with-max-jobs seems to be handled better. Which one do we want, or do we want both?
Both. They are slightly orthogonal currently, in that max-jobs controls the number of parallel compiler runs inside a single directory, whereas num-cpus controls the number of parallel make invocations (in different directories). Yeah, it's weird.
5) download has /usr/bin/perl hardcoded as interpreter; it should probably use "/usr/bin/env perl" instead. Suggested patch attached.
Looks good, pushed.
7) patches/apply.pl is unhappy about the version number returned by NetBSD's patch: Patch version 2.0-12u8-NetBSD Use of uninitialized value $ver_line in pattern match (m//) at /archive/cvs/libreoffice/build/patches/apply.pl line 924. Can't get patch version Usually, NetBSD patch works fine, do we want to force GNU patch or should I change it to accept NetBSD's patch as well?
Hm, I'd ask Fridrich or Petr to comment on that - there have been problems with different interpretation of fuzz, among various patch flavors -
And a final question: how do I need to change the wiki instructions for git+ssh access?
Like this: git clone ssh://[username@]git.freedesktop.org/git/libreoffice/build Thanks for your fixes! -- Thorsten
Attachment:
pgpr0VfpKsJVY.pgp
Description: PGP signature