Date: prev next · Thread: first prev next last
2012 Archives by date, by thread · List index


On 08-02-2012 12:51, Christian Lohmaier wrote:
Hi Anders, *,

On Tue, Feb 7, 2012 at 5:00 PM, Anders Holbøll<andershol@gmail.com>  wrote:

I wanted to have at look at the source code for the website. But I had a
little trouble finding it. Perhaps a little information should be added to
the wiki or made a little more obvious if it exists.
Oh, you did find it already...
I found a repository (that was incomplete and out-of-date), but I gather form your answer, that it is the correct one.

I'm curious: What are you trying to work on?
I wanted to see if I could contribute and scratch an itch, but didn't want to sidetrack this thread.

- A lot of language names are missing.

Yes, those are overridden/defined in the configuration file that is
not part of the repo (as it contains the database-credentials,
api-keys and the like)

But for the sake of transparency and completeness the l18n overrides:
[code snipped]
Thanks a lot for those, but it would of course be much nicer if they where in the repository. Note that the locale "lb" (presumably Luxembourgish), that seems to be new for the 3.5rc3, is missing (also from the live site).

- The /cms-code/mysite/code/UpdateDownloadsTask.php throws some errors e.g.
index out of range, but perhaps they are just ignored on the live site. I
fixed these locally.

UpdateDownloadsTask is not meant to be run by you or anyone else
besides the people who do add the binaries to the server. There is no
point in running it more often than after a new release is added to
the mirror system.
How do you run it to begin with?
I think, I have to run it locally to populate the Download-table. Otherwise the download-page is empty. I run it by visiting "DailyTask"-page in a browser.

It would be nice if the repository could be updated.
Well - patches welcome in any case.
Reading your mail doesn't give me that impression. In this instance, I don't see how I could send patches to bring the repository up-to-date. Sending other patches relative to some old version seems pointless.

The file /cms-code/mysite/_config.php seems to have been left out of the
repository because it contains the database-password.

Yes, as mentioned above it also contains recaptcha api keys and
email-addresses for logging,...

But that makes it
harder for a new developer to setup the site since the file probably also
contains a line like "Object::add_extension('SiteTree', 'Translatable');"
that isn't in the standard silverstripe _config.

The repo is not meant as a starting point to a new installation -
indeed it requires extensions like the one you mentioned, and also
decorators for the Subsite object for example.

Couldn't the password
therefore be put in another file, that could be excluded from git and
included in _config.php or just named e.g.
"/cms-code/mysite.secret/_config.php" so silverstripe will find it. The
"install.php" should probably also be included, although I am not sure it
turned out to be needed.

If you want to install, I'd just use silverstripe's installer module,
install it (i.e. let it setup the database&  .htaccess for you, as
that's basically all that is done when installing), and then replace
the files with the checkout.

The install.php is not needed if you setup the database yourself, and
have a corresponding .htaccess to pass the requests through
silverstripe in case the file doesn't exist on disk. The install.php
basically only checks whether your setup meets the requirements and
setup the database for you and adds the sample page.
I also ended up using a download from the silverstripe site to bootstrap the site locally, but since it isn't even documented which version of silverstripe is used (my git-foo wasn't strong enough), this seemed fragile.

And it would still be nice if all the non-secret config and customization could be included in the repository.

--
Anders

--
Unsubscribe instructions: E-mail to website+help@global.libreoffice.org
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://listarchives.libreoffice.org/global/website/
All messages sent to this list will be publicly archived and cannot be deleted

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.