Date: prev next · Thread: first prev next last
September 2011 Archives by date, by thread · List index


Hi Christoph,

On Tue, 2011-09-27 at 23:18 +0200, Christoph Noack wrote:
Cedric, I hope you're enjoying the hackweek (if you're still there),
please don't forget to sleep (especially if you're at home again).

Don't worry, I'm still sleeping ;)

Am Dienstag, den 27.09.2011, 09:45 +0200 schrieb Cedric Bosdonnat:
Hi Christoph,

On Sat, 2011-09-24 at 15:14 +0200, Christoph Noack wrote:
just checked the recent daily build ... some issues I've noticed when
playing around:
      * the indicator line is wider than the page (on the right side,
        for LTR) ... that looks a bit strange when zooming or working in
        book layout. Could you set the size according the page width?

Yep, but insert a note in one of the pages... you'll see that we
certainly want to find a compromise with that too ;)

Mmh, maybe I wasn't clear here? If I insert a note/comment, everything
works fine and the length of your page break line is extended
(correctly). It is just a bit wide like ... (below, its wider than the
page).

        br>------------------------------------------
            +------------------------------------+
            |                                    |
            |                                    |

With some more width computations, I should get the right side of the
page easily.

BTw, while writing that, I just realized that we may want to have the
buttons on the opposite side for RTL text... (header/footers as well).

      * When I added a header, the cursor (among with the page) jumped
        upwards. The area left and right to the pages weren't re-drawn,
        so parts of the page break indicators were visible. Clicking on
        them made them disappear.

Ok, I'll check that, there may be some redraw problems since I changed
that a lot.

Cool, thanks!

I also found a bug and a crash when undoing a page break... I'll need to
fix that after hackweek.

One last thing ... I don't know whether the button itself is a bit large
(good for the button handling, but visually it might be a bit strong ...
thinking about going towards a 16x16 icon).
@ Astron: What do you think?

I hesitated quite a long time on that... so your input there is highly
appreciated.

Phew, I don't have the "oh so great" solution at the moment, but I
played a bit with some ideas:
https://picasaweb.google.com/lh/photo/7HmsuAXxc8BJeGdELeqsUg?feat=directlink

In my personal view, #3 fits best - although stuff like brightness and
details (for the icon) and refinement (like decision on rounded edges)
is missing yet. But, I think that it fits well to the notes and the
header/footer indicators.

I personally like the round edges... but that's a matter of taste. The
control width, icon and arrow position seem more well balanced in your
#3 idea than on my implementation. Could you please give me the widths /
heights / positions you used?

I also made a quick revert of the page break color change yesterday
evening... but I find the colors used for the header/footer is too
similar while staying quite different: I'm not sure it's really
aesthetic.

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.