ESC meeting minutes: 2020-01-09

* Present:
    + Olivier, Eike, Stephan, Michael W, Caolan, Thorsten, Cloph, Gabriel, Michael S, Heiko, 
Ilmari, Miklos, Kendy

* Completed Action Items:

* Pending Action Items:
   + Propose new certified developers (Kendy, Stephan, Thorsten)
     + still waiting
   + make gnu make 4.0 a requirement on master (Michael S)

* Release Engineering update (Cloph)
   + 6.4 status
     + 6.4 rc2 is tagged, last bit was the python3 upgrade
     + 6.4 rc3 is still coming
     + Late features
       + ODF 1.3 possibly (Thorsten)
   + 6.3 status
     + 6.3.5 rc1 is end of January
   + Remotes
   + Android viewer: old core.git viewer is currently broken on master
     + both arch64 and x86 (crash on doc load, will investigate)
   + Online
     + libreoffice-6-4 branch is created

* Documentation (Olivier)
   + New Help
       + XHP editor now usable, added XML, XHP(DTD) and Dup ID check.
       + Several fixes in transformation to render page
       + Many refactors for UI (need more love)
       + Added search
       + Instructions: https://wiki.documentfoundation.org/DocumentationHelpEditor
       + did you reach out to get help, e.g. replace button list with a toolbar? (Kendy)
         + could be a GSoC project to improve this further
         + just implemented it as a PoC (Olivier)
   + Help Contents
       + Many screenshots additions  to master
       + several fixes in contents (Seth Chaiklin, ohallot)
   + Guides
       + Calc Guide 6.2 available
       + Math Guide 6.2 available

* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
       236(236) (topicUI) bugs open, 268(268) (needsUXEval) needs to be evaluated by the UXteam
   + Updates:
       BZ changes   1 week    1 month    3 months   12 months
            added      11(2)     24(-4)     51(1)      116(2)
        commented     108(66)   281(-23)   860(55)    2520(82)
          removed       0(0)      3(-1)      6(1)       17(1)
         resolved       4(0)     25(-7)     74(-4)     233(1)
   + top 10 contributors:
         Heiko Tietze made 175 changes in 1 month, and 1105 changes in 1 year
         Foote, V Stuart made 71 changes in 1 month, and 454 changes in 1 year
         Dieter Praas made 62 changes in 1 month, and 373 changes in 1 year
         Seth Chaiklin made 58 changes in 1 month, and 81 changes in 1 year
         kompilainenn made 46 changes in 1 month, and 319 changes in 1 year
         Xisco Faulí made 24 changes in 1 month, and 398 changes in 1 year
         Timur made 13 changes in 1 month, and 139 changes in 1 year
         m.a.riosv made 13 changes in 1 month, and 38 changes in 1 year
         Thomas Lendo made 12 changes in 1 month, and 253 changes in 1 year
         *UNKNOWN* made 12 changes in 1 month, and 12 changes in 1 year


   + New tickets with needsUXEval Dec/19-Jan/09

     + new: 7
     + easyhack: 2
       + Rename Default Style to Default Paragraph/Page/Table Style
         + https://bugs.documentfoundation.org/show_bug.cgi?id=129568
       + Populate the Description box of the Customize dialog with multiline
         tooltip from bug 108458
         + https://bugs.documentfoundation.org/show_bug.cgi?id=129720
     + needsux: 18
       + search dialog and find bar: bugs 72080, 119200, 129783, 129469, 129781
       + move, delete, and select all in sections: bugs 129733, 129735, 129737
     + reopened: 2
     + fixed: 3
     + duplicate, wontfix: 9

* Crash Testing (Caolan)
   +
29(-2) import failure, 4(+0) export failures
   + 0 (-14) coverity issues
   + 12 ossfuzz issues

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.2.8.2
        + (-15) 1157 1172 1195 1082 973 815 568 375 320 198 0
    + https://crashreport.libreoffice.org/stats/version/6.3.2.2
        + (-457) 1505 1962 2563 2578 2640 3124 3622 3487 4392 3950 3273 4801 1698 0
    + https://crashreport.libreoffice.org/stats/version/6.3.3.2
        + (-747) 2555 3302 4368 3674 3312 2629 1820 854 0
    + https://crashreport.libreoffice.org/stats/version/6.3.4.2
        + (+1073) 2057 984 0

    + Recent regressions without steps to reproduce

1. Since 6.3.4.2 -> Seems related to tdf#124270. Dennis ?
http://crashreport.libreoffice.org/stats/signature/ScRecursionHelper::PushFormulaGroup(ScFormulaCell%20*)

2. https://crashreport.libreoffice.org/stats/signature/TypeDescriptor_Init_Impl::getMutex()

3.
https://crashreport.libreoffice.org/stats/signature/ScDocument::RemoveSubTotalCell(ScFormulaCell%20*)

4. Only linux
https://crashreport.libreoffice.org/stats/signature/SfxItemPool::GetFrozenIdRanges

5. 
http://crashreport.libreoffice.org/stats/signature/oox::drawingml::chart::PlotAreaConverter::convertFromModel(oox::drawingml::chart::View3DModel%20&)
        -> Patch in gerrit: https://gerrit.libreoffice.org/c/core/+/86483


 + no big problems from 6.4? (Miklos)
   + looks OK (Xisco)
   + normally more crashreports get it when final is out

* Hackfests & Events (Thorsten)
  + hope to have one each quarter.
  + plans for this year:
    + FOSDEM 2020
         + HackFest February 3rd and 4th, again probably in Beta Coworking (after FOSDEM)
      + devroom is approved, will be on Saturday
        + talks submitted: Caolan, Thorsten (will do the lightning), Ilmari,
          Kendy, Andras, Pedro, Michael, Heiko, Xisco
      + CMS room might be interesting too (Thorsten)

* GSoC 2020 (Ilmari)
   + https://opensource.googleblog.com/2019/12/announcing-google-summer-of-code-2020.html
       + https://wiki.documentfoundation.org/Development/GSoC/Ideas
       + Please review the ideas for any obsolete ones
         + Not much has happened (Ilmari)
       + Please all of you at least came up with a new idea (Thorsten)
       + We have lots of good ideas (Heiko)
       + Would anyone want to mentor PPTX stuff like transitions or macro-related stuff? (Ilmari)
       + Org application opens soon (Thorsten)
         + 5th Feb is the deadline (Ilmari)
AI:          + will take care of the application process (Thorsten)

* mentoring/easyhack update
         committer...   1 week     1 month      3 months      12 months
                 open      94(41)     156(-6)       167(-6)       175(-8)
              reviews     864(490)   3733(-885)   13477(-794)   55149(-86)
               merged     322(120)   1362(-166)    4927(-149)   17772(150)
            abandoned      21(-11)     90(-5)       264(2)        906(8)
          own commits     244(53)    1109(-102)    4163(-208)   14833(97)
       review commits     116(45)     453(29)      1153(22)      4329(69)
       contributor...   1 week      1 month     3 months    12 months
                 open       56(10)      75(-9)      76(-8)      79(-8)
              reviews     1196(382)   2625(710)   3859(716)   6697(869)
               merged       44(21)     143(24)     251(30)     926(33)
            abandoned        9(1)       30(7)      203(8)      477(6)
          own commits       54(28)     156(29)     301(29)     954(21)
       review commits        0(0)        0(0)        0(0)        0(0)
   + easyHack statistics:
      needsDevEval 6(6)   needsUXEval 2(2)   cleanup_comments 205(205)
      total 255(255)   assigned 7(7)   open 233(233)
   + top 10 contributors:
         Seth Chaiklin made 43 patches in 1 month, and 52 patches in 1 year
         Weblate made 13 patches in 1 month, and 13 patches in 1 year
         Onur Yılmaz made 8 patches in 1 month, and 8 patches in 1 year
         LibreOfficiant made 7 patches in 1 month, and 90 patches in 1 year
         Yusuf Keten made 7 patches in 1 month, and 7 patches in 1 year
         Kemal Ayhan made 4 patches in 1 month, and 4 patches in 1 year
         Szabolcs Tóth (NISZ) made 4 patches in 1 month, and 13 patches in 1 year
         Pranam Lashkari made 4 patches in 1 month, and 10 patches in 1 year
         Henrie, Alex made 4 patches in 1 month, and 5 patches in 1 year
         Stepas Toliautas made 3 patches in 1 month, and 3 patches in 1 year
   + top 10 reviewers:
         Nabet, Julien made 252 review comments in 1 month, and 2417 in 1 year
         Meeks, Michael made 160 review comments in 1 month, and 748 in 1 year
         Adolfo Jayme Barrientos made 149 review comments in 1 month, and 974 in 1 year
         Timar, Andras made 124 review comments in 1 month, and 1337 in 1 year
         Kaganski, Mike made 121 review comments in 1 month, and 837 in 1 year
         Xisco Faulí made 110 review comments in 1 month, and 1042 in 1 year
         Bergmann, Stephan made 101 review comments in 1 month, and 1075 in 1 year
         Vajna, Miklos made 101 review comments in 1 month, and 1599 in 1 year
         Muhammet Kara made 100 review comments in 1 month, and 238 in 1 year
         Holešovský, Jan made 91 review comments in 1 month, and 974 in 1 year
   + Patches automatically abandoned:
       lok: change-annotations: fix not unique id and multiline changes ( Mert Tümer )
           - https://gerrit.libreoffice.org/#/c/82010
       sc: open hyperlinks when requested through context menu ( Mert Tümer )
           - https://gerrit.libreoffice.org/#/c/82012
       WIP: ODF export for XHTML: formulas as images, not MathML ( Michael Stahl )
           - https://gerrit.libreoffice.org/#/c/80479
       WIP increase the max no of cols to 16384 ( Noel Grandin )
           - https://gerrit.libreoffice.org/#/c/78558
       LOK: disable LOKit in unit-tests only after destroying all ( Mert Tümer )
           - https://gerrit.libreoffice.org/#/c/82180
   + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
         Elzem Atay

* Commit Access
   + None

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
   + sleep -5 weeks

* Jenkins / CI update (Christian)
   from:Thu Jan  2 14:28:33 2020
   master linux rel  jobs:  58 ok:  58 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master linux dbg  jobs:  51 ok:  48 ko:   2 fail ratio:  3.92 % break:   2 broken duration: 1.32%
   master mac rel    jobs:  22 ok:  22 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master mac dbg    jobs:  22 ok:  21 ko:   1 fail ratio:  4.55 % break:   1 broken duration: 3.68%
   master win rel    jobs:  82 ok:  73 ko:   9 fail ratio: 10.98 % break:   8 broken duration: 7.52%
   master win dbg    jobs:  82 ok:  79 ko:   3 fail ratio:  3.66 % break:   3 broken duration: 6.53%
   master win64 dbg  jobs:  84 ok:  75 ko:   9 fail ratio: 10.71 % break:   7 broken duration:13.46%
   master gerrit lin jobs: 542 ok: 438 ko:  59 fail ratio: 10.89% time for ok: mean:  19 median:  19
   master gerrit plg jobs: 476 ok: 325 ko:  99 fail ratio: 20.80% time for ok: mean:  29 median:  28
   master gerrit win jobs: 551 ok: 398 ko:  94 fail ratio: 17.06% time for ok: mean:  54 median:  55
   master gerrit mac jobs: 541 ok: 413 ko:  55 fail ratio: 10.17% time for ok: mean:  43 median:  25
   master gerrit all jobs: 480 ok: 269 ko: 126 fail ratio: 26.25% time for ok: mean: 116 median:  82
  + https://dev-www.libreoffice.org/tmp/gerrit_200109.html
  + tests that failed more than twice in last seven days:
     4 CppunitTest_sw_uwriter
     6 UITest_calc_demo
     7 CppunitTest_writerperfect_writer
     7 UITest_calc_tests3
     9 UITest_conditional_format

 + last week was OK
   + upgraded to a bad Jenkins version, fixed now
   + problem with the format of messages, fixed now
   + analysis from Stephan wrt hanging processes
     + see 
<https://www.mail-archive.com/search?l=mid&q=3edce68d-596c-83f3-560a-f8e28d0826d7@redhat.com>
   + perhaps rather just run the build in a container? (Michael S)
     + last timed we tried Docker, it didn’t work nicely for our purposes (Cloph)

* l10n (Sophie)
  + weird issue with Gerrit, manually resolved
  + Online.git creates Gerrit changes, so please don’t touch po files in git!
  + not a problem in core.git, have an interim repo there

* Graphics architecture (Thorsten)
 * https://pad.documentfoundation.org/p/ESC_graphics_architecture
 * skia / vulkan: to try it, export SAL_ENABLESKIA=1 on master (Miklos)
   + metabug: https://bugs.documentfoundation.org/show_bug.cgi?id=129062
   + Lubos works on this to make it the default on Windows (at some stage)
   + added a hack for Linux32 builds (Thorsten)
     + bottom line: what cpu baseline do we want to support?
       + current state: we require SSE, but not SSE2 (Michael S)
         + on Windows, this is explicit; on Linux, we depend on compiler default
         + 64bit always has SSE2
     + just works around the gcc crash for now

* docx/xlsx competitive marketing isues (Miklos)
 + docx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128194 7 open bugs
 + xlsx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128382 4 open bugs
  + unchanged from last week

* gstreamer for Windows (Ilmari)
   + https://gstreamer.freedesktop.org/documentation/deploying/windows.html
   + I did not understand this is possible and thus always droned on about VLC
   + any known blockers for shipping gstreamer on Windows?
     + rather work with something available on the system already (Miklos, Thorsten)
     + could be a good GSoC project (Thorsten)
       + AI: file GSoC idea about this (Ilmari)

* help needed with Scrolling API (Ilmari)
   + Hypra contractor wants to improve a11y, but needs guidance
   + https://lists.freedesktop.org/archives/libreoffice/2019-December/084002.html
   + https://bugs.documentfoundation.org/show_bug.cgi?id=118418
   + tried to reach out to them, no success so far (Miklos)


* QA update (Xisco)

   + Please help flesh out the monthly reports:
         https://nextcloud.documentfoundation.org/f/240871

   + UNCONFIRMED: 619 (+31)
       + enhancements: 78  (-3)
       + needsUXEval: 6 (-6)
       + haveBackTrace: 1 (-1)
       + needsDevAdvice: 11 (+0)
       + documentation:  3 (+1)
       + android:  5 (+0)
       + iOS:  0 (+0)
       + Online:  18 (+6)



   + Most pressing bugs:
    New:
        [None]

    Old:
       + FILEOPEN: Some labels in charts are not displayed by default
           + https://bugs.documentfoundation.org/show_bug.cgi?id=117088
           + Szymon?

        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, 
PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597
            + Thorsten looking at it

        + Save-As behavior on MacOS Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126638
           + not happening for everyone

        + After Update to 6.1.4 on macOS fonts are blurred on retina
display (xcode 10)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=122218
             + probably depends on xcode version (Xisco)
             + but newer xcode is required by notarization (Cloph)
               + ideal would be to build with xcode 10 entirely
               + HiDPI screen for Cloph would be great (Michael)
               + found out: not a regression, but it is from a user’s PoV


    Fixed:
        + Crash when trying to view property of a component from forms (gtk3)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=129484
           + Thanks to Caolán

        + Crash when trying to view property of a component from forms (gtk3)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=129484
           + Thanks to Caolán


   + New high severity bugs of the week:
       + Calc - long time to open file in 6.4 beta
           + https://bugs.documentfoundation.org/show_bug.cgi?id=128873
           + Ilhan?

       + CRASH: Scrolling down document
           + https://bugs.documentfoundation.org/show_bug.cgi?id=129887
           + Serge already fixed this

* QA stats
   + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
     +169  -61 (-133) overall)
     many thanks to the top bug squashers:
      QA Administrators       13
      Mike Kaganski           11
      Heiko Tietze            9
      NISZ LibreOffice Team   8
      Telesto                 6
      Caolán McNamara         6
      V Stuart Foote          5
      Buovjaga                5
      Xisco Faulí             5
      Julien Nabet            5

   + top 10 bugs reporters:
      sdc.blanco              13
      Mike Kaganski           8
      John                    4
      Xisco Faulí             4
      Telesto                 3
      b.                      3
      NISZ LibreOffice Team   3
      peter josvai            3
      Dagmara                 2
      yallabalagan            2

   + top 10 bugs fixers:
      Kaganski, Mike          11
      McNamara, Caolán        6
      Heiko Tietze            6
      Vajna, Miklos           3
      Szabolcs Tóth (NISZ)    3
      Adolfo Jayme Barrientos 2
      Justin L                2
      Németh, László          2
      Xisco Faulí             2
                              1

   + top 10 bugs confirmers:
      Heiko Tietze            17
      Dieter Praas            11
      kompilainenn            7
      Kaganski, Mike          6
      Nabet, Julien           6
      Xisco Faulí             5
      *UNKNOWN*               5
      Brinzing, Oliver        4
      m.a.riosv               4
      Foote, V Stuart         4


* Highest-Priority bugs (aka "MABs"):
  + http://bit.ly/2lJAAJI
    6.0 : 1/52 -     1 %  (+0)
    5.4 : 1/40 -     2 %  (+0)
    5.3 : 0/54 -     0 %  (+0)
    5.2 : 0/43 -     0 %  (+0)
    5.1 : 1/36 -     2 %  (+0)
    5.0 : 0/64 -     0 %  (+0)
    4.4 : 0/76 -     0 %  (+0)
    4.3 : 2/73 -     2 %  (+0)
    4.2 : 1/133 -    0 %  (+0)
    4.1 : 3/85 -     3 %  (+0)
    4.0 : 3/82 -     3 %  (+0)
    old : 6/244 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
  + more accurate - down to a single commit.
  + http://bit.ly/2dyIfDy
  +

    done by:
       Xisco Faulí            5
       Raal                   2
       Tõnnov, Mihkel         1
       Telesto                1


* Bibisected bugs open: keyword 'bibisected'
  + http://bit.ly/2cSCXlS
  +

    done by:
       Xisco Faulí            5
       Raal                   2
       Terrence Enger         1
       Tõnnov, Mihkel         1
       Telesto                1


* all bugs tagged with 'regression'
  + 1143(-13) bugs open of 9223(+14) total 2(-1) high prio.

    done by:
       Xisco Faulí             4
       NISZ LibreOffice Team   1
       Terrence Enger          1
       Telesto                 1
       kompilainenn            1
       Timur                   1
       Foote, V Stuart         1
       Nabet, Julien           1
       m.a.riosv               1


* ~Component   count net * high severity regressions
  + http://bit.ly/1HWHb3E
    UI            - 1(+0)
    Calc          - 1(+0)
    LibreOffice   - 0(-1)

  by OS:
    Mac OS X      - 1(+0)
    Linux         - 0(-1)
    Windows       - 0(+0)
    All           - 1(+0)


* ~Component   count net * all regressions
  + http://bit.ly/1BUdI8i
    Writer: other            - 323(-5)
    Calc                     - 226(-2)
    Impress                  - 132(+1)
    Writer: docx filter      - 72(+1)
    LibreOffice              - 64(-1)
    Draw                     - 44(-1)
    UI                       - 40(-3)
    Borders                  - 39(-3)
    Base                     - 35(+0)
    Crashes                  - 33(-2)
    Writer: perf             - 32(+0)
    Writer: other filter     - 30(+0)
    Writer: doc filter       - 29(-1)
    graphics stack           - 26(+0)
    RTL                      - 23(+0)
    filters and storage      - 22(+0)
    Printing and PDF export  - 19(+0)
    BASIC                    - 18(+0)
    Chart                    - 17(-1)
    framework                - 2(+0)
    sdk                      - 1(+0)