Date: prev next · Thread: first prev next last
2019 Archives by date, by thread · List index


 Commented here: 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=8a82100c8274d3c0e6d8386116fe8c48543fc4c3
     Le mardi 19 novembre 2019 à 11:22:49 UTC+1, Julien <serval2412@yahoo.fr> a écrit :  
 
  Hi Michael

There's no function "GetTextWidth" (or I missed it), so can't do this assertion.
See https://opengrok.libreoffice.org/xref/core/sw/source/core/text/portxt.cxx?r=7ade17fd#810

Julien
     Le mardi 19 novembre 2019 à 11:12:24 UTC+1, Michael Stahl <mst@libreoffice.org> a écrit :  
 
 On 19.11.19 09:20, Miklos Vajna wrote:
Hi Julien,

Oh sorry, I didn't realize this pattern is:

SetWidth(GetHeight())
SetHeight(GetHeight())

I thought it's:

SetWidth(GetHeight())
SetHeight(GetWidth())

With that in mind, the current code is just OK, the width of the
checkbox portion is the same as its height, since it's a square (and
that size depends on the font size).

Perhaps add a comment explaining this to make it easier for the next
person to understand. :-)

even better: add an assertion that the width and the height are the 
same, then you'll find out in case your assumption isn't true.

assertions are executable documentation :)
    

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.