Re: Wrong copy paste in SwFieldFormCheckboxPortion::Format ?

Hi Miklos,

I didn't understand the swap thing, indeed, both use rInf.GetTextHeight(  ):

    810 bool SwFieldFormCheckboxPortion::Format( SwTextFormatInfo & rInf )
    811 {
    812     SwPosition const 
aPosition(rInf.GetTextFrame()->MapViewToModelPos(rInf.GetIdx()));
    813     IFieldmark const*const pBM = 
rInf.GetTextFrame()->GetDoc().getIDocumentMarkAccess()->getFieldmarkAt(aPosition);
    814     OSL_ENSURE(pBM && pBM->GetFieldname( ) == ODF_FORMCHECKBOX, 
"Where is my form field bookmark???");
    815     if (pBM && pBM->GetFieldname( ) == ODF_FORMCHECKBOX)
    816     {
    817         Width( rInf.GetTextHeight(  ) );
    818         Height( rInf.GetTextHeight(  ) );
    819         SetAscent( rInf.GetAscent(  ) );
    820     }
    821     return false;
    822 }

So putting "Height" first would change nothing.

    817         Height( rInf.GetTextHeight(  ) );
    818         Width( rInf.GetTextHeight(  ) );

Julien

On 18/11/2019 09:18, Miklos Vajna wrote:
> Hi Julien,
>
> I would just swap the width/height and wait for the first use-case that
> indeed wants a vertical (rotated) checkbox.
>
> Regards,
>
> Miklos