On 15.04.2019 10:44, Adrien Ollier wrote:
OutputDevice::AcquireGraphics() is a pure virtual function, so we cannot
know in the general case what it does.
And what is written is not really equivalent to what you wrote because
if AcquireGraphics() is false, there is not a second check for
mpGraphics. That's why it is an issue.
AcquireGraphics() is not just "any function". Despite someone could of
course implement it to play poker, its purpose is to acquire mpGraphics
and return if it succeeded. Failing that is programmer's error breaking
contract. There's no use to introduce that kind of checks here. Please
see existing implementations, like VirtualDevice::AcquireGraphics() in
vcl/source/gdi/virdev.cxx.
--
Best regards,
Mike Kaganski
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.