Date: prev next · Thread: first prev next last
2019 Archives by date, by thread · List index


Hello everybody,

working on bug #74702<https://bugs.documentfoundation.org/show_bug.cgi?id=74702> led me to read 
file core/vcl/source/outdev/nativecontrols.cxx.

I think there is an issue here:

[cid:679fb8e4-9553-43c2-8c2b-0c2e2a238558]

If mpGraphics == nullptr and AcquireGraphics() == false, then the second if does not return false 
and we execute the instruction of the return statement but this will lead to a crash (because 
mpGraphics is false in this scenario).

If the second if is correct, then the last instruction sould be:
​return mpGraphics ? mpGraphics->IsSupported(nType, nPart) : false;

What do you think about that ? Do you agree with me ?

Adrien Ollier

PNG image


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.