On 15.04.2019 10:33, Adrien Ollier wrote:
Hello everybody,
working on bug #74702
<https://bugs.documentfoundation.org/show_bug.cgi?id=74702> led me to
read file core/vcl/source/outdev/nativecontrols.cxx.
I think there is an issue here:
If mpGraphics == nullptr and AcquireGraphics() == false, then the second
if does not return false and we execute the instruction of the return
statement but this will lead to a crash (because mpGraphics is false in
this scenario).
No, please check what AcquireGraphics() does. Namely, it is used here to
acquire mpGraphics when it's not yet available. In fact, lines 166-167
are equivalent to this: "if (!mpGraphics) AcquireGraphics(); if
(!mpGraphics) return false;"
--
Best regards,
Mike Kaganski
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.