Re: scary / too subtle overload

Hi Lionel,

On 04/10/18 16:49, Lionel Elie Mamane wrote:
> In include/svtools/brwbox.hxx:
>
> class SVT_DLLPUBLIC BrowseBox
> {
> public:
>     bool            IsColumnSelected( sal_uInt16 nColumnId ) const;
>     // IAccessibleTableProvider
>     virtual bool                    IsColumnSelected( long _nColumn ) const override;
> }
>
> Function overload based on different integer types, one virtual, the
> other not. <sarcasm> What could possibly go wrong? </sarcasm>

        Good catch =)

> I'm tempted to rename one of the two... if it is LibreOffice-internal
> only. I'm afraid both are part of our public API, but I'm not sure how
> to check that again.

        Neither can be part of our public UNO API since they're not
isJavaNamed() - so I think you're fine.

        Thanks for tackling !

                Michael.

-- 
michael.meeks@collabora.com <><, GM Collabora Productivity
Hangout: mejmeeks@gmail.com, Skype: mmeeks
(M) +44 7795 666 147 - timezone usually UK / Europe