Maarten,
Thanks for your suggestion here and your earlier contributions to the Cppcheck Report. I agree that
we should create the include file dynamically. However the approach used by your script seems like
overkill. Cppcheck already finds that quoted includes like
#include "GraphicExportFilter.hxx"
.
Also when there seems to have been a coding style that all <> includes outside of /inc folders
should be defined by their relative path. Cppcheck only complains about 4 missing includes that do
not follow this pattern.(see my earlier email on oddball includes).
Unless, I'm missing something, I still prefer this approach:
$ find . -type d \( -name "inc" -o -name "include" \) |sort > inc.txt
inc.txt only has ~200 entries, where as /tmp/tmpfile.txt has ~1,800 after sorting it.
-Luke
Context
- Re: Cppcheck: Reduction of False Positives: Manual Approach · Luke Benes
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.