Hi,
On Wed, Oct 25, 2017 at 03:40:25PM +0200, Thorsten Behrens wrote:
there's another nit, see gerrit comment - I wonder if it's not a
better idea to push those checking efforts into gerrit instead? I know
some projects who use that rather extensively, also for style guides
like naming conventions, documentation and the like.
I very much agree. The barrier to entry for our project is already high enough
on all platforms. Throwing a "Error: clang-format is not found in $opt_lo or in
your PATH." pre-commit at unsuspecting newcomers pre-commit isnt going to help
at all.
This really should be part of CI infra.
Best,
Bjoern
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.