Date: prev next · Thread: first prev next last
2017 Archives by date, by thread · List index


Hi all,

so while poking around for tdf#99352, I created a local branch where most
contructions of VclPtr<> from a raw pointer have been replaced with an explicit
construction of a VclPtr<>. I havent used anything fancy (clang rewriter), just
some vim macros. I didnt catch all, but the majority of them I guess.

Question: Do we want that on master?

Having killed the remaining uses of operator=(someptr*) and then removing it
might make finding fishy vcl-foo much easier. Killing the remaining ones could
either be a bit-for-bit EasyHack or a something for clang plugin. So should I
push what I have on master? Im asking as I would need to rebase the patch over
other debug changes I did to find leaking VclPtrs<>, so asking here first
before doing that and pushing to gerrit.

Opinions?

Best,

Bjoern

FWIW: the changes are along the lines of:

-    mpPage = pPage;
+    mpPage = VclPtr<TabPage>(pPage); 

with mpPage being a VclPtr<> and pPage being a raw pointer.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.